Category[Is] and related tests #2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! There is just Scalafmt failure. Would you run sbt prePR and commit the changes ? |
|
@kailuowang Thanks! I'll figure it out soon. |
Codecov Report
@@ Coverage Diff @@
## master #2759 +/- ##
==========================================
+ Coverage 95.34% 95.34% +<.01%
==========================================
Files 363 363
Lines 6782 6788 +6
Branches 290 283 -7
==========================================
+ Hits 6466 6472 +6
Misses 316 316
Continue to review full report at Codecov.
|
|
@kailuowang This should be OK now. |
LukaJCB
reviewed
Mar 31, 2019
| /** | ||
| * The category instance on Leibniz categories. | ||
| */ | ||
| implicit val leibniz: Category[Is] = new Category[Is] { |
There was a problem hiding this comment.
Can we give thise one a more verbose name? Something like catsEvidenceCategoryForLeibniz? :)
There was a problem hiding this comment.
The Category instance for As is named as liskov -- so I copied that :-)
LukaJCB
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #2720 .